I think things change with time. The song you posted "Hawaa ka sipahi" is one of the classics from the early 80s along with "Har Gharhi tayyar Kamran" made for the Army. Both have very memorable lyrics that will never go out of fashion.
As such, to me what is important are the lyrics and poetry and then a catchy tune.
In the ones that came out in the 90's, nothing comes close to Alamgir's "Tum hi say aye mujahido" for the meaningful lyrics and the overall tone suitable for the youth of the 90s.
Vital Signs definitely did their part from time to time, but one of the recent ones that I have liked was "Shaheen-e-Pakistan" sung by Atif Aslam. That one has good, meaningful lyrics.
Some songs are complete and utter misses.